caspion icon indicating copy to clipboard operation
caspion copied to clipboard

Published 20 hours ago • verified publisher icon brafdlog

Add an icon for opening each exporter results

Open brafdlog opened this issue 4 years ago • 10 comments

For each type of exporter, add an icon that when clicked will open the relevant exporter

  • Csv and json will open the file
  • Ynab will open the ynab website in the correct url in the default browser
  • Sheets will open the google sheet we are exporting to in the default browser

brafdlog avatar Dec 15 '20 19:12 brafdlog

Good idea!

baruchiro avatar Dec 18 '20 10:12 baruchiro

@baaraak Do you want to take this?

baruchiro avatar Jun 10 '21 18:06 baruchiro

Sure, no problem... We are talking about this screen right?: Untitled I will take a look later and let you know if I have any question about how should I implement it

baaraak avatar Jun 11 '21 10:06 baaraak

I can take it.

ErezBiren avatar Jan 11 '23 22:01 ErezBiren

Fixed in #445

ErezBiren avatar Jan 25 '23 02:01 ErezBiren

@ErezBiren Tried it now.

First, it is working even if an exporter is disabled, I don't know if it is the wanted behavior.

Second, nothing happened when clicking on the JSON exporter.

baruchiro avatar Jan 25 '23 07:01 baruchiro

  1. @baruchiro @brafdlog Would you like the open result button to be hidden or disabled when the exporter is disabled?

  2. The JSON exporter results seem to work fine for me. Did you check that the file path is correct?

ErezBiren avatar Jan 25 '23 22:01 ErezBiren

1 makes sense to me Havent tried the json yet, can try later

brafdlog avatar Jan 26 '23 14:01 brafdlog

Ok, but to hide or should we disable the button?

ErezBiren avatar Jan 26 '23 14:01 ErezBiren

Hide

brafdlog avatar Jan 26 '23 18:01 brafdlog