Brad Zacher

Results 390 comments of Brad Zacher

Not that I know of. If it's important to you, consider submitting a PR upstream.

With any issue in opened in this project - it either has a visible progress in the form of an attached PR, or it has no progress. We are a...

I love this idea in theory - the issue is that it's going to be a major breaking change for most of our users - which is difficult to stomach...

Note that the dependency is specifically a type-only import - it is not a runtime dependency. https://github.com/typescript-eslint/typescript-eslint/blob/407a37430d5a8ff59e111993b2585ee162fef821/packages/ast-spec/src/token/PunctuatorToken/PunctuatorTokenToText.ts#L1 We purposely do not declare a peer dependencies on typescript in any of...

definitely the optional peer dep so we're explicit (I know yarn2 can break sometimes without this): https://github.com/typescript-eslint/typescript-eslint/blob/b15a2b2a02dc9af2b47b77eb3aede73ffa85ac66/packages/typescript-estree/package.json#L69-L73 As for some form of "manually define the new enum members" hack so...

> Why was that necessary? It's not a `.d.ts` file because it contains enum declarations which we need exposed at runtime.

Sorry to delay. I've been taking some personal time off of open source for the last few weeks (trying to avoid anything non-trivial). I'll get back to this next week....

Oookay. First up - in regards to the build process.. Yeah it is pretty hacky. In a nutshell: When I split the AST spec into its own "package", I had...

Interesting - I tried quickly adding `bundledPackages: ['typescript']` to the config, and it crashed api-extractor: ``` ERROR: Internal Error: Unable to analyze the export "SyntaxKind" in /Users/bradzacher/git/typescript-eslint/node_modules/typescript/lib/typescript.d.ts You have encountered...

I was just wondering if we could hackily solve this with a one-line change. But the bug prevents it. 🤷 I'm fine with cutting that line of thinking there. For...