light_painter icon indicating copy to clipboard operation
light_painter copied to clipboard

Experimental version does not work on van 1.17

Open Nico314159 opened this issue 3 years ago • 2 comments

Steps to Reproduce: Download the experimental pack and run it on van 1.17.

Expected Outcome: The pack loads.

Observed Outcome: It didn't load and my log file took this dump.

Other Info: I have an M1 Mac but I'm not sure that's the only problem because this works for me on van 1.16 and this works for me on van 1.18.

[09:59:06] [Render thread/INFO]: Caught error loading resourcepacks, removing all selected resourcepacks enf$c: Failed to load shader: minecraft:shaders/post/transparency.json at enf.z(SourceFile:542) ~[1.17.jar:?] at enf.e(SourceFile:741) ~[1.17.jar:?] at enf.f(SourceFile:752) ~[1.17.jar:?] at enf.a(SourceFile:723) ~[1.17.jar:?] at dvo.b(SourceFile:2245) ~[1.17.jar:?] at dvo.a(SourceFile:2169) ~[1.17.jar:?] at eji.a(SourceFile:364) ~[1.17.jar:?] at ra.a(SourceFile:100) ~[1.17.jar:?] at ra.a(SourceFile:18) ~[1.17.jar:?] at pm.a(SourceFile:21) ~[1.17.jar:?] at aqu.c(SourceFile:151) [1.17.jar:?] at aqy.c(SourceFile:23) [1.17.jar:?] at aqu.z(SourceFile:125) [1.17.jar:?] at aqu.bq(SourceFile:110) [1.17.jar:?] at dvo.f(SourceFile:1077) [1.17.jar:?] at dvo.e(SourceFile:730) [1.17.jar:?] at net.minecraft.client.main.Main.main(SourceFile:217) [1.17.jar:?] Caused by: wz: Invalid shaders/program/aggregate_1.json (resourcepack): Couldn't compile fragment program (resourcepack, aggregate_1) : ERROR: 0:20: Invalid call of undeclared identifier 'texture2D' at wz.a(SourceFile:48) ~[1.17.jar:?] at emx.(SourceFile:161) ~[1.17.jar:?] at enl.(SourceFile:31) ~[1.17.jar:?] at enk.a(SourceFile:302) ~[1.17.jar:?] at enk.a(SourceFile:149) ~[1.17.jar:?] at enk.a(SourceFile:90) ~[1.17.jar:?] at enk.(SourceFile:59) ~[1.17.jar:?] at enf.z(SourceFile:524) ~[1.17.jar:?] ... 16 more Caused by: java.io.IOException: Couldn't compile fragment program (resourcepack, aggregate_1) : ERROR: 0:20: Invalid call of undeclared identifier 'texture2D' at dpz.b(SourceFile:72) ~[1.17.jar:?] at dpy.a(SourceFile:41) ~[1.17.jar:?] at emx.a(SourceFile:182) ~[1.17.jar:?] at emx.(SourceFile:140) ~[1.17.jar:?] at enl.(SourceFile:31) ~[1.17.jar:?] at enk.a(SourceFile:302) ~[1.17.jar:?] at enk.a(SourceFile:149) ~[1.17.jar:?] at enk.a(SourceFile:90) ~[1.17.jar:?] at enk.(SourceFile:59) ~[1.17.jar:?] at enf.z(SourceFile:524) ~[1.17.jar:?] ... 16 more

Nico314159 avatar Jan 27 '22 18:01 Nico314159

Was able to fix manually by changing every "texture2D" in a .vsh or .fsh file to just "texture"

Nico314159 avatar Jan 27 '22 20:01 Nico314159

Also, I think there should be a way to configure the range of the experimental version back down to 40, cause otherwise performance takes too big of a hit. (In a superflat peaceful world I get 200-300 fps without the pack and 10-20 with it).

Nico314159 avatar Jan 27 '22 21:01 Nico314159