Brad King
Brad King
From https://github.com/InsightSoftwareConsortium/ITK/issues/4407#issuecomment-1898120975: > At least I can now 100% confirm that v3.27.9 works, and starting with v3.28.0 it doesn't. @kislinsk @phcerdan please try building CMake from source and `git bisect`...
`Modules/ThirdParty/VNL/UpdateFromUpstream.sh` uses the older `Utilities/Maintenance/UpdateThirdPartyFromUpstream.sh` script. My update was to `Utilities/Maintenance/update-third-party.bash`.
I'll look at converting `Modules/ThirdParty/VNL/UpdateFromUpstream.sh` to use the newer script.
I've updated #2324 to switch to the new script.
#2324 demonstrated an update with only a few files from VNL changed. Can this be closed?
@hundeboll thanks. In general we don't accept pull requests directly to this fork. It exists only to stage upstream PRs that haven't been merged there yet. This PR is toward...
See KWSys [Encoding.hxx](https://gitlab.kitware.com/utils/kwsys/blob/abb8c680927708b161f87fb596cefb454ef5e97d/Encoding.hxx.in#L50-60) and [Encoding.h](https://gitlab.kitware.com/utils/kwsys/blob/abb8c680927708b161f87fb596cefb454ef5e97d/Encoding.h.in#L30-49).
Some interfaces take lists of canonical options, others take flags as command-line string fragments. In general, settings with `_FLAGS` in their name take command-line string fragments, and settings with `_OPTIONS`...
> lists are the correct way to go for add_compile_options right? Yes. CMake will quote/escape things for you. Same for `target_compile_options`. > But how does add_compile_options() interact with CMAKE__FLAGS? Both...
> what I just wrote there is essentially the recommended way of handling this? Yes, though I'd be interested in an example of what flags you might propagate to consumers,...