Brad Campbell

Results 658 comments of Brad Campbell

> which means Flux was never enabled 🙃 . Why not default to enabled, rather than disabled? It seems like someone who has included flux intends to use it, and...

With adding that to the kernel cargo.toml I'm seeing errors: ``` ❯ make ci-job-flux ******************************************************************************** * CI-Job: Flux * ******************************************************************************** source tools/ci/flux-ci-runner/deps.sh check && cargo flux Checking tock-registers v0.10.0 (/Users/bradjc/git/tock/libraries/tock-register-interface)...

> > Why not default to enabled, rather than disabled? It seems like someone who has included flux intends to use it, and the case where flux is included but...

> > ## Testing Strategy > > travis > > We haven't used travis for nearly a decade 😛 Feels like just yesterday.

I can't red x my own PR, but using the same name as the trait https://github.com/tock/tock/blob/4ad42c94bb66b8204f5e14e8f0b986521d8a6f9e/kernel/src/scheduler.rs#L20 gets us in trouble. For example, calling the chip `Chip` conflicts when you need...

I maybe like `InUse` eg `SchedulerInUse`, `RestartPolicyInUse`, etc.

Assigned to @alevy as chair of @tock/x86-wg.

This is a big improvement. Before this PR in boards: ``` ❯ git grep -e '^static mut' | wc -l 244 ❯ git grep -e '^pub static mut' | wc...