Brad Campbell

> I think I was mostly irritated by the single letter type parameters in the macro definition macros are generally bad

I remember a conversation somewhere where we said the convention in both Rust and Tock is single letters for types but not for constants. I thought that was the understanding...

I don't think we have any capsules that take a grant as an argument to the component `new()` function. Someone should try that to see what it looks like to...

> > I don't think we have any capsules that take a grant as an argument to the component new() function. > > You mean "take a **capability**" right? No,...

Does Rust care if you create a struct and implement all capabilities for it, and then use it for something that only needs one? Related, do we permit one object...

> I would lean to a "one Cap per struct" policy I think. For a capsule I think that makes sense. Process Console needs two: https://github.com/tock/tock/blob/754e045fe8cd22be3d8cd3a7a470f17bf3cbd846/capsules/core/src/process_console.rs#L225-L230 But if the goal...

Maybe we should prohibit unsafe in the components crate. ``` ❯ pwd /Users/bradjc/git/tock/boards/components ❯ git grep unsafe | cat src/debug_writer.rs:unsafe impl capabilities::ProcessManagementCapability for Capability {} src/debug_writer.rs: unsafe { src/debug_writer.rs: unsafe...

> [@hudson-ayers](https://github.com/hudson-ayers) so this is relying not on the the use of `unsafe` in the macro, but rather the explicit presence of an `allow(unsafe_code)` in the macro implementation. That allow...

We've run into this issue: ```rust pub struct PMCapability; unsafe impl capabilities::ProcessManagementCapability for PMCapability {} unsafe impl capabilities::ProcessStartCapability for PMCapability {} type ProcessInfoDriver = capsules_extra::process_info_driver::ProcessInfo; let process_info = components::process_info_driver::ProcessInfoComponent::new( board_kernel,...

- [ ] Remove grant capability creation from all components - [ ] Resolve the need for the type to be passed to both the component constructor and the static...