Brad Campbell

Results 658 comments of Brad Campbell

I think last-call should check that no reviews are requested as well.

One concern: in some cases it is critical that the AppID is not assigned unless the process has a valid credential. The traits should make this requirement obvious, and not...

I guess this just needs to advance beyond draft form.

> I suggest we merge this without the ninedof driver, which relies on #3719, which is basically blocked on figuring out that peripheral. This board is useful to have also...

The relevant piece from the datasheet: ![image (7)](https://github.com/tock/tock/assets/1467890/a98e301c-9fe8-4718-8540-bc6b3e3a02e3)

Can you get any known response from the sensor? Something like a status or chip id?

> I tried reading the chip_id, and it returns 0x24, which is what it supposed to do. Hmm, in that case, it seems like some setup/configuration step might not be...

Where does shared code, like the nrf52 crate, go?

## Idea 6: Diff in tracking issue Open a tracking issue for the change needed for the next release. Include the diff required to implement the change in the issue...

My pushback to all of the automatic/cfg/etc. options is that we would effectively be maintaining two versions of the kernel (and giving users a [relatively] easy option to use either)....