Brad Hards

Results 306 comments of Brad Hards

There are two conventions for quaternions: Hamilton and JPL. The right answer depends on the convention. A 180 rotation could be associated with using the wrong convention (there are other...

Given it works on ppc64el and fails on ppc64, my guess would be some endianess issue. I have no idea what though - not even whether the problem is in...

Conceivable, but it looks like there are failures on the 8 bit RGB test, which should not be affected by endianess conversions....

@fancycode Can you re-run on master? I'm not expecting it to work, just that there is a new test that might (or might not) point to the underlying issue.

It does appear to be byte order dependent. Recommended removal of the values check for 1.19.0 and I will try again with a uint16_t version later.

It might be safer to check for exactly 8 bits, because uncompressed will do packed in some situations (e.g. 5-6-5).

@farindk thank you for the work on this.

Note for further investigation: maybe we need clap for the thumbnail.

I won't argue license interpretation, but if you want an encoder that is not x265, kvazaar could be an option.

I think this got feedback, and can be closed.