ish. icon indicating copy to clipboard operation
ish. copied to clipboard

ish without PHP

Open ccoenen opened this issue 12 years ago • 2 comments

I put the url-parsing into client-side havascript, ish will now work from any HTTP-Server. It will also work direclty from your filesystem as well.

ccoenen avatar Nov 27 '12 11:11 ccoenen

I did the same thing to get it working with my asp server. Used js to force a iframe update

coryrylan avatar Nov 27 '12 20:11 coryrylan

I looked into it, it's very similar, indeed. One thing we're doing differently is the approach to applying the URL. In my case, this change is contained in this line here: https://github.com/ccoenen/ish./commit/8fe62a884f00239c3b9c5160b941dba50a10958d#L1R22

When the page loads, i read the url= variable. This way you a Reload the page and/or deep link to a page inside of ish. On the other hand, i (intentionally) don't return false in the end, because i use exactly that reload to update the iframe-source. (i basically set the url-variable in the URL and this reloads the page, on load the right iframe-src will be set anyway).

This is not meant as a judgement of either solution. I merely point out the differences.

ccoenen avatar Nov 28 '12 13:11 ccoenen