shipit icon indicating copy to clipboard operation
shipit copied to clipboard

Patch for Module::Install::XSUtil.

Open typester opened this issue 14 years ago • 4 comments

use_ppport() function provided by M::I::XSUtil is generate ppport.h automatically, so ignore missing ppport.h file when this function found in Makefile.PL

typester avatar Jan 20 '11 02:01 typester

Hi, is this patch still relevant? I'm taking over the maintenance of shipit. Bump it if this still needs to be merged.

miyagawa avatar Jul 21 '12 22:07 miyagawa

I think so. I usually use this patch in my environment

typester avatar Jul 23 '12 01:07 typester

Ok, i feel a little bit too dirty about adding individual module support like this though.

What do you think about moving the manicheck after perl Makefile.PL? I'm not really sure what was the reasoning behind doing so after make distclean in the first place.

miyagawa avatar Jul 23 '12 06:07 miyagawa

I think that is smarter way, I don't remember ShipIt API though..

typester avatar Aug 17 '12 09:08 typester