gomemcache
gomemcache copied to clipboard
bradfitz
TLS support
Support of memcached TLS
Add support for the (experimental) TLS feature of memcached TLS
Function NewWithTLS(config *tls.Config, server ...string) *Client is added. Simply pass in a *tls.Config whose settings match those of the memcached daemon, then all other methods of gomemcache operate identically to those of the normal (non-TLS) case.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@bradfitz Ping. Can you please take a look at this and maybe merge it?
It will be great to have TLS support for this client.
I'd prefer a new exported field on Client, not a new constructor.
Also, each server shard might have its own hostname/tls.Config. The option on Client should be more like TLSConfigForerver func(target string) (_ *tls.Config, ok bool) probably.
Ideally there would be tests too. I tried to run it against memcached built with TLS enabled and I couldn't even get memcached on Debian stable to work. (I'm surprised it'd need anything newer, so I was likely holding it wrong but then ran out of time.)
Ideally there would be tests too. I tried to run it against memcached built with TLS enabled and I couldn't even get memcached on Debian stable to work. (I'm surprised it'd need anything newer, so I was likely holding it wrong but then ran out of time.)
I've addressed this part. This package now has better tests & GitHub Actions CI hooked up.
I'm very sorry @bradfitz and @QuChen88, I just don't have the hours in my day at present to adjust my PR based on Brad's comments .........
Turns out we don't actually need this since #158, @bruceesmith. That hook already provides everything necessary to do TLS dials.
I sent #169 to add a test & mention in the docs.