eslint-plus-action icon indicating copy to clipboard operation
eslint-plus-action copied to clipboard

A better approach for PRs from forks (workflow commands via stdout)

Open jnm2 opened this issue 3 years ago • 1 comments

If you write workflow commands to stdout instead of making web API calls which depend on the token, the authentication issue mentioned at https://github.com/bradennapier/eslint-plus-action#handle-forked-prs goes away and the performance may even be better.

Example from docs page (https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message):

echo "::warning file=app.js,line=1,col=5::Missing semicolon"

Both warning and error inline annotations can be created this way. A GitHub action using this approach: https://github.com/cschleiden/jest-github-actions-reporter

jnm2 avatar Mar 31 '21 23:03 jnm2

Yes that is new -- this was made back when they didn't have support for actions in forked repos so a lot of the craziness is built around a method i found to make it work properly.

bradennapier avatar May 27 '22 21:05 bradennapier