eslint-plus-action icon indicating copy to clipboard operation
eslint-plus-action copied to clipboard

A Disgusting PR

Open bradennapier opened this issue 5 years ago • 1 comments

Wow, this is really ugly huh? Look at the ugly GitHub sweater of a change-set this PR wants to merge. Yucky.

bradennapier avatar Jun 19 '20 13:06 bradennapier

Eslint Summary

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 8 8
Warnings 7 0

[failure] prettier/prettier

  • src/constants.ts Line 15 - Delete ⏎⏎⏎
  • src/constants.ts Line 21 - Delete ····
  • src/eslint.ts Line 56 - Insert ;
  • src/eslint.ts Line 63 - Insert ;
  • src/eslint.ts Line 86 - Insert ;
  • src/eslint.ts Line 143 - Replace annotation.path}#L${annotation.start_line}-L${annotation.end_line})·Line·${annotation.start_line with ⏎········annotation.path⏎······}#L${annotation.start_line}-L${annotation.end_line})·Line·${⏎········annotation.start_line⏎······
  • src/fs.ts Line 12 - Insert ,
  • src/utils.ts Line 26 - Replace ·).map((e)·=>· with ).map((e)·=>

[warning] @typescript-eslint/no-unused-vars

Disallow unused variables

  • src/api.ts Line 1 - 'github' is defined but never used.
  • src/api.ts Line 130 - 'client' is assigned a value but never used.
  • src/fs.ts Line 12 - 'unused' is defined but never used.

[warning] @typescript-eslint/no-explicit-any

Disallow usage of the any type

  • src/api.ts Line 52 - Unexpected any. Specify a different type.

    • [SUGGESTION] Use unknown instead, this will force you to explicitly, and safely assert the type is correct.
    • [SUGGESTION] Use never instead, this is useful when instantiating generic type parameters that you don't need to know the type of.
  • src/fs.ts Line 12 - Unexpected any. Specify a different type.

    • [SUGGESTION] Use unknown instead, this will force you to explicitly, and safely assert the type is correct.
    • [SUGGESTION] Use never instead, this is useful when instantiating generic type parameters that you don't need to know the type of.
  • src/types.ts Line 16 - Unexpected any. Specify a different type.

    • [SUGGESTION] Use unknown instead, this will force you to explicitly, and safely assert the type is correct.
    • [SUGGESTION] Use never instead, this is useful when instantiating generic type parameters that you don't need to know the type of.

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

  • src/fs.ts Line 12 - Argument 'unused' should be typed with a non-any type.

github-actions[bot] avatar Jun 19 '20 13:06 github-actions[bot]