Brad Smith

Results 207 comments of Brad Smith

Also looking at the recipe the patch for clang/lib/Lex/InitHeaderSearch.cpp doesn't do anything anymore as the header path handling was moved to clang/lib/Driver/ToolChains/Haiku.cpp -- Haiku::AddClangSystemIncludeArgs(). This changed with 18. https://github.com/llvm/llvm-project/commit/aa2c701b5dc04330b8ec4084a94d7cbe9cc938eb

I don't know how I missed the build issue with llvm-jitlink as I swear it went through a build without issue. https://github.com/llvm/llvm-project/commit/2e0a105761cd33e42b915da5aab35c966daf8241 I pushed the llvm-jitlink fix. https://github.com/llvm/llvm-project/commit/d3bcd9b16badac301d4f29cf401387ae5e14999f

Also looking at coming up with a slightly better llvm-config diff that doesn't use #ifdef. Something like this.. ``` diff --git a/llvm/tools/llvm-config/llvm-config.cpp b/llvm/tools/llvm-config/llvm-config.cpp index d5b76b1bb6c1..30cb748b10b3 100644 --- a/llvm/tools/llvm-config/llvm-config.cpp +++ b/llvm/tools/llvm-config/llvm-config.cpp...

> > Also looking at coming up with a slightly better llvm-config diff that doesn't use #ifdef. > > Should've know better I gues ;) replaced the above with the...

> Pushed a commit to a branch on my fork: [Begasus@57b1c11](https://github.com/Begasus/haikuports/commit/57b1c111aacb8e3d9ad8b4620f8e662d43d18043) > > This contains the work from here and suggested changes. Could be nice if someone else beside me...

@Begasus Just FYI there was a regression release of 18.1.8.

From an OpenBSD perspective this looks pretty important.

> While I see the benefit of auto-detecting cc as well, I do not see any reasoning for why you also change the default. I mean it ultimately is two...