judgebot
judgebot copied to clipboard
bra1n
Change a card language
What do you think about adding as reaction flags representing the available languages for the card that has been fetched so that you could change it language on the fly? This can be useful when you have 2 people talking about a card but e.g. one is more used to the english keywords while the other is more used to the french ones.
If you think this is a good feature idea, I can also work on it and submit a PR for it :)
Also, thanks for the amazing bot!
I think that's a great idea, but keep in mind that the bot already returns localized versions of a card if requested. On top of that, only the requesting user can use the emoji reactions to control the results of a query. If those 2 constraints would be fine for your idea, I'd love to see a PR for it! :+1:
but keep in mind that the bot already returns localized versions of a card if requested
Yes, with the lang:$lang query, which is great!
On top of that, only the requesting user can use the emoji reactions to control the results of a query.
Ah I didn't know that :)
It makes the feature just a bit less convenient that I intended, but still works I think: if you wanted a specific language for the card but forgot to use the lang: param (which I personally wouldn't know it existed if I haven't went through the repo's issues), you can still use the flags to request the language you originally wanted.
I'll get working on that! I love the bot, I'll be more than happy to contribute :)
Yes, with the
lang:$langquery, which is great!
Actually, Scryfall (the API that we use for fetching cards) already returns localized cards if they match your generic query. What we do then is to simply show the appropriate language flag if the card that will be displayed is non-English. So your feature could probably tie into that.
About the restriction for the requesting user: think of a channel with a few hundred people in it - if everyone were able to "control" judgebot responses, it would be pretty easy to troll people or generally disturb every single query through that. Hence the rather strict limitations.