Ben Prather

Results 34 comments of Ben Prather

I like this. It was a handful of lines to put together a prototype and it feels like as a "breaking" change it should go in with the file format...

Agreed re: option. An expanded naming option should be easy enough to put into the logic, and as a bonus I feel less bad not checking with every downstream before...

Going to take a look at this soon I swear... One additional option recently came up in multi-scale simulations: we should also have `dn = int` output options, for outputting...

Linking #939 in case whoever fixes this wants to take a crack at some of those while they're in the parser code (or replacing it!)

Not quite. `free` and `disconnect` nominally do exactly the same thing: destroy the communicator. The only difference is synchronicity. Since both the `Driver` and `Mesh` are torn down before `MPI_Finalize`...

1. If it's only for `MeshData`, but does the same thing, why not make it another overload of `Add` (or actually, maybe name both `GetOrAdd`)? I think I could pull...

Oooh, if I had any artistic skill, trying to draw computers into a Greek vase style would be hilarious. Anyway, re: readability: ![image](https://github.com/parthenon-hpc-lab/parthenon/assets/3892634/d7be0e8b-e822-44cf-8bd6-61de742c5372) Beyond still needing the usual alignment tweaks...

Comments from Parthenon meeting: 1. Add some visualization of mesh refinement: squares of descending size, perhaps in the column top or initial letter P, or behind name if not too...

@par-hermes format

Should all be done; it doesn't seem like constexpr breaks compiling or operation (for me). Generally, I'm not sure small PRs like this & #777 deserve changelog entries. There's always...