vs-code-bpmn-io icon indicating copy to clipboard operation
vs-code-bpmn-io copied to clipboard

Support ability to set colors

Open vkatushenok opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe

Continuing work on existing diagrams that use colors (e.g. set via Cawemo or Camunda Modeler) is not fully possible.

Describe the solution you'd like

Would be great to bring palette of at least same x6 colors used across BPMN.io based tools. As a minimal and flexible setup, palette / "colorize" could be an extension option in a format of CSS supported string array with defaults already pre-set

Feature description & example: https://bpmn.io/blog/posts/2016-colors-bpmn-js.html

image

vkatushenok avatar Mar 30 '21 09:03 vkatushenok

Thanks for reporting 👍

pinussilvestrus avatar Mar 30 '21 11:03 pinussilvestrus

Hi @vkatushenok 👋🏻, nice to see that after all this time you still care about BPMN. 💟

philippfromme avatar Apr 06 '21 08:04 philippfromme

Hi @vkatushenok 👋🏻, nice to see that after all this time you still care about BPMN. 💟

Haha, I still strongly believe in process automation and BPMN(.io) is still the best tool to model those 😉 .

vkatushenok avatar Apr 07 '21 00:04 vkatushenok

Closing as duplicate as this is being tracked with https://github.com/bpmn-io/bpmn-js/issues/1491.

smbea avatar May 19 '22 07:05 smbea

Still, we will need a bpmn-js bump to make it work (which is not automated by now).

pinussilvestrus avatar May 19 '22 08:05 pinussilvestrus

re-opened and linked it in the other issue. We can mark it as fixed-upstream to be updated when the feature is merged.

smbea avatar May 19 '22 08:05 smbea

Hello there, I would be interested to have this feature in the extension 🙂 do you accept new contributors and PRs ?

tpucci avatar Nov 08 '23 08:11 tpucci

@tpucci Yes, we very much welcome contributions! Feel free to pick this up and ask questions.

philippfromme avatar Nov 08 '23 08:11 philippfromme

@tpucci Yes, we very much welcome contributions! Feel free to pick this up and ask questions.

Great ! I will try to add this feature in the coming days.

I assume this ability would be opted-in, isn't it ? Should we add a "bpmn-js.additionalModules": ["color-picker"] user setting ?

tpucci avatar Nov 08 '23 08:11 tpucci

@tpucci I don't think it's necessary to make the color picker opt-in. It's just one additional entry in the context pad, and users can simply ignore it.

philippfromme avatar Nov 08 '23 09:11 philippfromme

I created a PR #145. Let's continue the discussion there 👍

tpucci avatar Nov 09 '23 10:11 tpucci

Hi @philippfromme, PR #145 is ready to be merged. Can you review it ? 🙂

tpucci avatar Nov 15 '23 08:11 tpucci