dmn-js icon indicating copy to clipboard operation
dmn-js copied to clipboard

Package inferno version

Open nikku opened this issue 6 years ago • 0 comments

Is your feature request related to a problem? Please describe.

It is dangerous to rely on inferno as being used as a peer dependency, as our version of inferno may very well conflict with the inferno version being used by applications embedding us.

Describe the solution you'd like

Pack inferno within the application and provide a clear import to consume it, e.g.

import { Component } from 'dmn-js-shared/vendor/inferno';

...

Consecutively replace all usages of inferno with dmn-js-shared/vendor/inferno (or table-js/vendor/inferno, pointing both to a single version of the library).

Describe alternatives you've considered

None.

Additional context

We faced the exact issue when building an extension for dmn-js (cf. https://github.com/bpmn-io/dmn-js/issues/391).

nikku avatar Feb 26 '19 15:02 nikku