Ben Potter

Results 317 comments of Ben Potter

@ammar - Correct on both points. Edited to a root-level command.

> I think this issue conflates two different things. I see resource metadata as an aid to introspection of the workspace: tell me about the workspace I'm in, like /proc/cpuinfo....

> The value should be able to be a link. What do we think about making that markdown? > > I was thinking we could embed multiple values inside a...

I'm not really sure what additional features you're looking for as a part of this issue. Exposing key/value pairs within the shell of the resource itself can be achieved with...

> Any open question is whether the metadata should be associated with resources or with the workspace as a whole? After a chat with @kylecarbs, we settled on metadata associated...

I realized the single-block-per-resource was missing an indicator of whether metadata is sensitive. I added that to the Terraform in [this comment](https://github.com/coder/coder/issues/2989#issuecomment-1190267113) under `coder_metadata.dev_info.values.api_key` `{ sensitive: true, value: "asfdjkl" }`

> Possibly a dumb question, but why do we need to explicitly create a `null_resource`, as opposed to just denoting "global" metadata fields by leaving the `resource_id` unset? Is it...

> Should I interpret the above to mean that this is now scoped to be just about showing which resources are allocated to a workspace and which secrets are needed...

> Another thing that occurs to me is that the current design implies that we're showing the type field in the UI as though it was an "automatic" metadata field....

@kylecarbs and I chatted a bit and landed on a better solution for key/value pairs using Terraform's block syntax. Updated [the comment in this issue](https://github.com/coder/coder/issues/2989#issuecomment-1190267113) ```diff - values = {...