Bryce Plunkett

Results 44 comments of Bryce Plunkett

Totally understand! Forgive my questions! I'm just trying to understand your use case and poke its edges to see how `pg-schema-diff` can slot into it. I think, to rephrase the...

No worries! I suspect you folks might run into issues with the "online [check|not null] constraint" addition and "online index replacement" (assuming no concurrently). I haven't really tested if that...

Sweet! This shouldn't be too much code, but it does get into the nitty gritty of the internal of the library. There are couple parts to this: 1. Identifying if...

I'm excited to have you take on this ticket @tanryberdi . You can see an [example of the problem here](https://github.com/stripe/pg-schema-diff/blob/main/internal/migration_acceptance_tests/partitioned_index_cases_test.go#L66), where one column is inconsistently formatted. This problem is pervasive...

> >Thanks for confirming. I will close this issue as a duplicate. > > The fix requires updating the underlying diff tool from migra to pg-schema-diff. It will likely be...

Looks right to me! Don't worry about making the "dry-run" mode too complicated, i.e., printing out line numbers. Just printing out the file name is fine.

You still planning on picking this up @ammiranda? Checking because I might take at a pass at it soon.

Yes, you can use the same cobra/flags pkg, similar to the pg-schema-diff command. I would define the script under a file like `scripts/acceptance_test_sql_linter/main.go`. You could then use `go run` to...

Think of it like this. You have an existing view foobar that references columns fizzbuzz.color and fizzbuzz.value. Your new schema has foobar but it references a new column fizzbuzz.new_value and...

Very basic `VIEW` support was added. I won't close this out until the feature is as fleshed out as I would like.