katafygio icon indicating copy to clipboard operation
katafygio copied to clipboard

Allow configuration of git author, email and check interval

Open Joibel opened this issue 5 years ago • 4 comments

This is a simple change to allow configuration of a few hardcoded git options that I'd like to be able to configure.

10 second pushing is too frequent for my use. I'm pushing to gerrit, which expects each user to register their author details, so I'd like to be able to change those.

Joibel avatar Aug 18 '20 12:08 Joibel

Coverage Status

Coverage increased (+0.2%) to 86.552% when pulling 542a0e767e7076f2b1542414201432d0e96848e6 on Joibel:feature/gitconfigopts into d0a1ad8bf1da233443bb637638df96ea55bb9cc4 on bpineau:master.

coveralls avatar Aug 25 '20 14:08 coveralls

All LGTM, I assume the configurable interval is meant to batch more to reduce noise on high churn surges, is that the case?

Wondering if "commit+push soon if possible, not more than once per user-defined-interval" could be a finer option (as in: archive quickly, with commit timestamps close to the change's timestamp when possible, but batch if needed)? Wdyt?

bpineau avatar Nov 29 '20 18:11 bpineau

I'll rebase this, and split the username stuff out and have a look at your idea. It does make sense. It is about reducing noise, and I actually some more filters for that. I'll see what I can do about that patch too and see what it looks like after that.

Joibel avatar Nov 29 '20 18:11 Joibel

Hi @joibel, did you made progress on this PR ?

Will this allow us to reduce the numbers of commits/push to something like one per hour/day maximum ?

sadortun avatar May 01 '21 19:05 sadortun