fritzctl icon indicating copy to clipboard operation
fritzctl copied to clipboard

Add new fields to Thermostat

Open jayme-github opened this issue 4 years ago • 2 comments

Added the new fields (as of AVMs docs):

  • WindowOpenEnd
  • Boost
  • BoostEnd
  • Holiday
  • Summer

As this makes the cli output quite long, I've added a verbose option to hide most of the new fields by default.

Seems like we where working on the same stuff in parallel today. :smile: I'm not sure about the types in model.go. You seem to prefer to parse everything as string and I am not sure why that is. Let me know if you would like to have that changed.

As of the window stuff at least all my devices seem to not report the state properly.

jayme-github avatar Jan 22 '21 19:01 jayme-github

Codecov Report

Merging #235 (32732f8) into master (4874fa4) will decrease coverage by 0.61%. The diff coverage is 79.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   99.95%   99.33%   -0.62%     
==========================================
  Files         107      108       +1     
  Lines        2056     2101      +45     
==========================================
+ Hits         2055     2087      +32     
- Misses          1       11      +10     
- Partials        0        3       +3     
Impacted Files Coverage Δ
fritz/thermostat.go 40.00% <0.00%> (-60.00%) :arrow_down:
cmd/jsonapi/converter.go 95.00% <42.85%> (-5.00%) :arrow_down:
fritz/epoch.go 92.85% <92.85%> (ø)
cmd/list_thermostats.go 97.53% <94.44%> (-2.47%) :arrow_down:
fritz/next_change.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4874fa4...32732f8. Read the comment docs.

codecov[bot] avatar Jan 22 '21 19:01 codecov[bot]

Hi @jayme-github, thanks for taking the time to contribute. I will try to look into this PR as soon as I can.

bpicode avatar Jan 24 '21 12:01 bpicode