Brian Pickrell
Brian Pickrell
Use the Excel sheet at the above link for the correct command lines; these are now obsolete
Charlie thinks we'll have to create a new OneHot operation in Migraphx, similar to what we did for Resize. Need to confirm that this is necessary and document the reasons...
Don't review this yet! It's very incomplete and I just created the PR to make it easy to visualize the changes so far.
Reviewers: This PR isn't quite ready for review as I'm still working on the GPU implementation. I'm just opening it to activate the Jenkins testing.
This PR is finally ready to begin review. Note that I left a "todo" about recalculating the indexing order in the Reference op. If we come up with a way...
The licensing check fail now occurring is for a file not related to this PR: ``` Error: The licenses for the following 1 file(s) either... do not match the year...
> Looks fine, just a few small things. I haven't been able to fully wrap my head around all the math in the ref and gpu impl, the index changes...
> Looks fine, just a few small things. I haven't been able to fully wrap my head around all the math in the ref and gpu impl, the index changes...
Requesting re-review after a recent change: Added a Python test `test_roialign.py` to check MigraphX output directly vs. onnxruntime, and found that MigraphX results were internally consistent but output the right...
Confirmed it also works on MI300 for good measure, although this should have been GPU-independent.