Benjamin Pasero

I would have exected "Start Review" to be the only green button: 

Deadlock between Watcher and Debounce threads (fix #187)

2

fix https://github.com/parcel-bundler/watcher/issues/187 There are two threads involved in `Watcher.cc` and `Debounce.cc` each calling into respective methods of the other and thus each potentially holding onto locks of the other. This...

Allow to consume with C++ sources to build as part of `npm install`

4

I think ever since https://github.com/parcel-bundler/watcher/commit/062bca4887f17a2f448c11a99bfc2f826eb98c3e, components that depend on `@parcel/watcher` no longer compile the module from its C++ sources but get prebuild versions. In VS Code we require to build...

macOS: Error starting FSEvents stream with many folders

4

It seems there is a maximum of folders that can be watched. Anywhere from 500 paths, I see an `false` return from the call to `FSEventStreamStart`. ``` ~/Desktop/parcel-test> node index.js...

Deadlock between `Watcher` and `Debounce` threads

2

Ever since https://github.com/parcel-bundler/watcher/commit/9b7c657df8ad1c0d020541eae0dd38b921c94fb8 landed, we have tried to update to newer versions but in VS Code events would stop at random and not recover. Now I had some time to...

Undo from finder/explorer does not report file events

3

**Steps:** * setup parcel watcher according to docs, simply watching a folder [1] * create a sub-folder in that watched folder * create a file in that sub-folder * from...