secsgem icon indicating copy to clipboard operation
secsgem copied to clipboard

Adding proposed ballot "collection event namelist request"

Open Dreanaught opened this issue 7 years ago • 4 comments

To request currently definded collection-events from a given equipment there is a proposed ballot within the SECS standard which has been requested by hume (proposed ballot item 4824B, Oct 2011)

It has been helpful to me beeing able to ask the equipment what collection_events it has defined. Here is the implementation for that on the equipmenthandler

Dreanaught avatar Nov 13 '17 13:11 Dreanaught

Coverage Status

Coverage decreased (-0.4%) to 99.275% when pulling 0a7eaaf0b8100994e109f52ab7b4f61deb798e9c on Dreanaught:Adding-proposed-Ballot-"Collection-Event-Namelist-Request" into 477cc82015ee469bf19065712b3f402d5717a642 on bparzella:master.

coveralls avatar Nov 14 '17 07:11 coveralls

I would love to improve the coverage, but currently i have no clue how to do that.

Dreanaught avatar Nov 14 '17 07:11 Dreanaught

Thank you for your merge request, your input is much appreciated.

The coverage is due to missing tests for the new code. To raise the coverage again, you need to write tests, that runs all the lines of the new function.

If you don't have any idea about how to write the tests I can do that for you or support you with that.

bparzella avatar Nov 15 '17 16:11 bparzella

I would apprechiate it if you could write the tests for me. I will look into them to learn for the next time how it is done.

Dreanaught avatar Nov 20 '17 09:11 Dreanaught