pdfmake icon indicating copy to clipboard operation
pdfmake copied to clipboard

Margin 0 is not applied when overriding existing margin

Open kryops opened this issue 3 years ago • 0 comments

Hi there,

I noticed a small bug around the override behavior of the different margin properties: If they are set to 0, they are not applied when a margin has already been applied through an inferior property or style inheritance:

{
  content: [
    'inline styles:\n\n',
    { text: 'marginLeft: 10, margin: 20', marginLeft: 10, margin: 20 },
    { text: 'marginLeft: 10, margin: 0 (NOT APPLIED)', marginLeft: 10, margin: 0 },
      
    '\n\nmargin: 20 from style\n\n',
    { text: 'overridden with margin: 10', style: 'margin', margin: 10 },
    { text: 'overridden with margin: 0 (NOT APPLIED)', style: 'margin', margin: 0 },
    { text: 'overridden with marginLeft: 10', style: 'margin', marginLeft: 10 },
    { text: 'overridden with marginLeft: 0 (NOT APPLIED)', style: 'margin', marginLeft: 0 },
    
    '\n\nmarginLeft: 20 from style\n\n',
    { text: 'overridden with 10', style: 'marginLeft', marginLeft: 10 },
    { text: 'overridden with 0 (NOT APPLIED)', style: 'marginLeft', marginLeft: 0 },
    { text: 'overridden with margin: 10', style: 'marginLeft', margin: 10 },
    { text: 'overridden with margin: 0 (NOT APPLIED)', style: 'marginLeft', margin: 0 },
  ],
  styles: {
    margin: {
      margin: 20,
    },
    marginLeft: {
      marginLeft: 20,
    }
  }
}

Thanks for looking into it!

kryops avatar Nov 07 '22 16:11 kryops