Božidar Ševo

Results 13 comments of Božidar Ševo

> Maybe we could adopt the guideline from [Airbnb](https://github.com/airbnb/swift): Thanks! I agree, their guideline looks good, should I just reference it or we can copy it and reference it with...

> should I just reference it or we can copy it and reference it with the link what do you think @soundsokay ?

I started working on this and I am maybe more in for not adding the margins. We have multiple screens that we push from the product details and if we...

> [`cellLayoutMarginsFollowReadableWidth`](https://developer.apple.com/documentation/uikit/uitableview/1614849-celllayoutmarginsfollowreadablew) - have you tried this? will try it out, tnx for the tip!

> Blaze view Looks like the Blaze view is a SwiftUI view `BlazeCampaignCreationForm` (embedded in `BlazeCampaignCreationFormHostingController`) so we can make a different approach, just to limit the width to some...

Connected to https://github.com/woocommerce/woocommerce-ios/issues/11210

Do we have any usual copy/text that we use in these cases?

> @bozidarsevo We use the struct [Notice](https://github.com/woocommerce/woocommerce-ios/blob/f810789a9b3efbde3e4c00132aad44ba07dbc673/WooCommerce/Classes/Tools/Notices/Notice.swift#L8) with "Undo" as action title. See [here](https://github.com/woocommerce/woocommerce-ios/blob/f810789a9b3efbde3e4c00132aad44ba07dbc673/WooCommerce/Classes/ViewRelated/Orders/Order%20Details/OrderDetailsViewController.swift#L815) for an example. Would it maybe have more sense to show confirmation alert instead of showing...

Would something like this work? ![Simulator Screen Recording - iPhone 15 Pro - 2024-01-09 at 10 31 47](https://github.com/woocommerce/woocommerce-ios/assets/6242034/773e3086-9f7f-4c78-a5ab-e65e2d7ecf23) I added an undo notice when item is removed, I was thinking...

Do we need to update https://github.com/woocommerce/woocommerce-ios/blob/trunk/docs/tracking-events.md? Maybe just to write that `import protocol WooFoundation.Analytics` needs to be used?