wp-plugin-leaflet-map icon indicating copy to clipboard operation
wp-plugin-leaflet-map copied to clipboard

Published 20 hours ago • verified publisher icon bozdoz

feat: 2-way shortcode helper inputs; resolves #68; fixes translations?

Open bozdoz opened this issue 1 year ago • 8 comments

bozdoz avatar Sep 19 '22 02:09 bozdoz

@hupe13 wondering if you know if the plugin is localized; I have no clue how to get i18n working.

bozdoz avatar Sep 20 '22 00:09 bozdoz

You are using _e(). When you publish the development tree (trunk) or the stable Release the translators will see this here. I see the shortcode helper page in German, except "Reset Shortcodes", this is a new string.

Or what do you mean?

hupe13 avatar Sep 20 '22 08:09 hupe13

No, that's what I wanted to hear! I just have no idea how the translations work. Just newly generated a .pot file; so hopefully when this gets merged, that "Reset Shortcodes" button will be updated, eventually

bozdoz avatar Sep 20 '22 17:09 bozdoz

Actually you don't need a pot file at all, as far as I understand it. I do not have one in my plugin.

hupe13 avatar Sep 20 '22 19:09 hupe13

wow, interesting

bozdoz avatar Sep 20 '22 21:09 bozdoz

You are using _e().

The statement is incomplete. Must be: You are using _e() with a text domain.

hupe13 avatar Sep 21 '22 05:09 hupe13