Adam Bozanich comments

Results 88 comments of


                                            Adam Bozanich

akash client to report a version mismatch between the client & server

We actually have the `/version` endpoint: https://github.com/ovrclk/akash/blob/1ab8ee6ebd1321d98fb899c8661316cf182a4d4d/provider/gateway/rest/router.go#L95-L99

multiple error requesting account, post failed: Post <rpc> EOF's

are you hosting your own node for rpc? if not, which are you using?

multiple error requesting account, post failed: Post <rpc> EOF's

A provider should have its own non-public node, @arno01. [cosmos-omnibus](https://github.com/ovrclk/cosmos-omnibus) is a good way to spin one up.

akash tx update response & behavior when provider is out of resources

Thanks all for the report. Interesting case. Few thoughts: * Some kind of optional `--force` with a clear message around it is a good suggestion. * Inventory "overcommit" can be...

stopping putting context.Context in a struct

What does it say? Is it a pattern/style recommendation or something related to memory management?

stopping putting context.Context in a struct

I kinda think it's an over-opinionated comment. Check out where we use it - I'm open to changing it but I don't think we absolutely have to just based on...

lint: prohibid shadowed variables

Is there a linter for this in `golangci-lint` or elsewhere? I'd have to see some examples of issues from shadowing; I tend to prefer shadowing over using contrived names.

lint: prohibid shadowed variables

ah, cool. we're already running [`go vet`](https://github.com/ovrclk/akash/blob/b224ebcebefa0d01002437d81346a4b30e200938/Makefile#L86-L87) [here](https://github.com/ovrclk/akash/blob/b224ebcebefa0d01002437d81346a4b30e200938/.github/workflows/tests.yml#L45)

update CLI documents not to reference "uatom" or fractional tokens

The `--gas-prices` argument can use fractional tokens. It uses an `sdk.DecCoin` instead of an `sdk.Coin` - the underlying amount is a decimal not an integer.

[provider] inventory service detects non-existing node

@arno01 FYI you can also hit the `/status` endpoint of a provider to get its inventory information. See [here](https://gist.github.com/boz/5e2ddf6674dc00dd675f88f9af395e35)