eventcatalog
eventcatalog copied to clipboard
fix(core): show non-latest consumers and producers
Motivation
Fix https://github.com/boyney123/eventcatalog/issues/85.
Have you read the Contributing Guidelines on pull requests?
Yes.
This is my first stab at fixing https://github.com/boyney123/eventcatalog/issues/85. I'd like to know, if this is already enough for the first iteration and if not what is missing.
Two things I noticed:
1.: The existing getAllEventsAndVersionsFlattened
seems to be buggy (excluding the most recent versions, because of a line which was commented out) and not returning full events (just som fields). That's why I made getAllEvents
to allow returning versions as well.
2.: I stumbled over several problems, because noImplicitAny
is not set in the tsconfig.json
. Am I allowed to introduce this in another PR? For example the whole implementation of truncateNode
in graphs.ts
didn't really made any sense currently (see my fixed version). I'm also wondering if it was actually used correctly (centerNode
used it for id
so I did the same for leftNodes
and rightNodes
, but I'd assume you want it for name
...?).
⚠️ No Changeset found
Latest commit: 4a6817f49956f39c0653483aa6d380579d639b4f
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
eventcatalog-docs – ./
🔍 Inspect: https://vercel.com/davidboyne123/eventcatalog-docs/JBZQb9AVCGd7pJivPW5ikRN56nQg
✅ Preview: Ignored
[Deployment for 4a6817f canceled]
eventcatalog-example – ./
🔍 Inspect: https://vercel.com/davidboyne123/eventcatalog-example/FY3RWKraw5J7m6kCugeFEqpj4K6H
✅ Preview: Ignored
[Deployment for 4a6817f canceled]
Hey @donaldpipowitch , sorry for the late review here, think EventCatalog has evolved since these PR were raised. Going to close for now, if you need this feature, feel free to raise again and I will take a look ASAP. Sorry it's taken so long!