phoenix_integration icon indicating copy to clipboard operation
phoenix_integration copied to clipboard

Add a follow_all api to test that all links on a page go somewhere valid

Open boydm opened this issue 5 years ago • 6 comments

@marick I'm thinking of adding a new validation api to extract all links on a give page into a list, then scan the list to make sure each link goes somewhere valid. Essentially a scan for broken links. I think it would be useful for blog posts and such where some of the links may be hand-built in markdown.

Thoughts?

boydm avatar Nov 02 '20 21:11 boydm

Sorry for the delay. I don't have any opinion.

I do have a somewhat-related idea of parsing error messages out of a form and presenting them in a way people can easily check, so as to avoid grovelling through the HTML with regular expressions.

I also need to replace the custom assertions I added with the library I since released: https://github.com/marick/flow_assertions

I'm obsessively-focusing on a declarative library for testing (at first) form handling at the Ecto changeset level. Some dated documentation: https://marick.gitbook.io/idiosyncratic-elixir/declarative-testing-of-structured-form-input/preface

It'll be interesting to see if I can handle the common cases tersely and declaratively while still allowing weird cases to be handled in a traditional "do this, then this, then check this" style.

marick avatar Nov 09 '20 01:11 marick

No problem.

I like the work you've done on flow_assertions. Should integration take a dependency on it?

boydm avatar Nov 09 '20 01:11 boydm

I plan to make a pull request for that dependency someday. I made some API changes so it's not an entirely trivial change.

marick avatar Nov 12 '20 00:11 marick

I added a pull request on this a while back. Did you see it?

marick avatar Apr 25 '21 21:04 marick

Sorry. Didn't been totally swamped with Scenic, which is waaaaaay more work than I always expect.

boydm avatar Apr 25 '21 23:04 boydm

Hey @marick, I'm doing some maintenance on phoenix_integration. Is this one fixed?

Also, it's been fairly stable for quite a while. Thinking of calling it 1.0. What do you think?

boydm avatar Sep 25 '21 18:09 boydm