DataExplorer icon indicating copy to clipboard operation
DataExplorer copied to clipboard
verified publisher icon boxuancui

Added intuitive colors and color option

Open davidr9708 opened this issue 3 years ago • 1 comments

  1. I added more intuitive colors to identify the state of the colors to avoid any kind of MISLEADING interpretation. Ex: "Red = remove" is more intuitive to know that column needs to be removed than the default ggplot colors (blue or pink).

  2. I added a color option if anyone wants to use other colors (which might be more intuitive for them)

davidr9708 avatar Sep 23 '22 15:09 davidr9708

My pull also solves the inconsistency problem mentioned here: https://github.com/boxuancui/DataExplorer/issues/129

davidr9708 avatar Sep 23 '22 15:09 davidr9708

Hi @davidr9708 , would you mind pulling your PR into the latest master, since there are some updates in the same file. Apologies for the inconvenience.

boxuancui avatar Feb 07 '23 18:02 boxuancui

Don't worry, I just pulled it with the new updates of the master branch, please, I'm sure there's not any problem but please, test it before merging it

davidr9708 avatar Feb 08 '23 02:02 davidr9708

Thank you so much @davidr9708 ! I will merge within a few days. Having a busy week and thanks for your patience!

boxuancui avatar Feb 08 '23 18:02 boxuancui

Duplicate of #177

boxuancui avatar Feb 08 '23 18:02 boxuancui