boxeehack icon indicating copy to clipboard operation
boxeehack copied to clipboard

Fixed selected episode jumping to the top of the list after playing an item

Open oscahie opened this issue 12 years ago • 5 comments

This commit fixes the issue described at https://github.com/boxeehacks/boxeehack/issues/371

Additionally I've reworked from scratch the code that searches for the last unwatched episode, which is now simpler and faster (since it breaks the loop as soon as the first watched episode is found). I've tested this code with as many corner cases as I could think off and it worked flawlessly.

oscahie avatar Feb 20 '13 20:02 oscahie

Please ignore the other commit (d794ac4), it's the first time I use git and didn't realize the pull request would include both commits I had made on my fork. Hopefully you can cherry-pick the commits to merge...

oscahie avatar Feb 20 '13 20:02 oscahie

I hope this gets used in the next release

Kepners avatar Feb 24 '13 19:02 Kepners

this should be merged, it fixes core functionality

mrplow avatar Apr 14 '13 20:04 mrplow

Thanks for this. The jumping to the top was bothering my wife. lol

booyakafoo avatar Apr 22 '13 22:04 booyakafoo

You should also be able to rebase this commit, so you only got your own commit in this PR. In your branch run: git fetch; git rebase origin/development

Hope git doesn't give any troubles. Then git push –f for overriding this PR with the new data. Which only should be yours.

kimegede avatar May 20 '13 13:05 kimegede