Anders Hovmöller
Anders Hovmöller
@charettes For me the point of freeze_time is that you create a world where time related things are predictable and portable across machines. Leaving the time zone as is will...
@charettes You should try my fork! https://github.com/boxed/freezegun/ We freeze time on all tests by default (see also https://medium.com/@boxed/flaky-tests-part-3-freeze-the-world-e4929a0da00e). Our unit test suite took 8 minutes when I introduced this freeze-everything....
Seems it takes ~2.2 minutes compared to with my fork 20.2 seconds. So better than 8 for sure, but still pretty bad I'd say. Give my fork a try! And...
> Are you saying basically ignoring the time zone offset (in whatever direction) is a good thing? The _system_ time zone? Absolutely. I would even consider it a critical bug...
What time zone are you in?
Yea, it's probably the same as https://github.com/spulec/freezegun/issues/348
You need to give at least the full stack trace. It would also help seeing your code that triggers this.
Is the little underscore the entire problem?
Thanks for looking into this and finding the cause!
I think it might be a bit much to say it's intentional just because the tests actually check it :P The tests could have been black box tests and then...