gurk-rs icon indicating copy to clipboard operation
gurk-rs copied to clipboard
verified publisher icon boxdot

File corruption

Open pcrockett opened this issue 10 months ago • 2 comments

I tried sending myself a .zip file, and a .zip.sha256sum file via Signal's "Note to Self" feature. I sent the file using Signal Desktop on one computer, and received it using gurk on another computer. Both files ended up corrupted after receiving them from gurk.

I was able to use xxd to find out that both files had a bunch of null bytes appended to them.

gurk 0.6.1

pcrockett avatar Feb 17 '25 10:02 pcrockett

Thank you for reporting this. I will look into it.

boxdot avatar Feb 17 '25 17:02 boxdot

@boxdot I just noticed today that all my files have null bytes appended to them. I just haven't noticed until now because many file formats don't find this to be a problem.

The only reason I noticed the problem for my zip file is because the zip file format puts important information at the very end, so it's the only file format that gave me errors when trying to open the file.

pcrockett avatar Feb 24 '25 09:02 pcrockett

Fixed upstream in https://github.com/whisperfish/presage/pull/307. Integration of the fix into gurk tbd

boxdot avatar Mar 24 '25 08:03 boxdot

If I read the dependencies right, it looks like it's in the main branch. Now just need a release.

pcrockett avatar Jun 27 '25 17:06 pcrockett

Looks like it's fixed in 0.7.2. Thanks!

pcrockett avatar Nov 02 '25 13:11 pcrockett