box-ui-elements icon indicating copy to clipboard operation
box-ui-elements copied to clipboard

feat(persistent-onboarding): Add renderAvatar property to ContentPreview

Open robertjk opened this issue 2 years ago • 2 comments

In Persistent Onboarding project I need to add a tooltip over Avatar component inside Preview. For that to work I defined renderAvatar property, which can be passed down in EUA and wrap this component in a tooltip. If renderAvatar is not defined Avatar will render normally, so the old code will still work as it used to.

robertjk avatar Apr 26 '22 12:04 robertjk

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Robert J. Kusznier seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 26 '22 18:04 CLAassistant

Changes look good to me, but there is an outstanding question from @jstoffan. Also, are there any unit tests that need to be updated as well?

ConradJChan avatar Apr 27 '22 20:04 ConradJChan