box
fix(ContentPreview): A11Y - remove index zero to avoid tab stops
fix(ContentPreview): A11Y - remove index zero to avoid tab stops
The file preview itself is contained in one <div> elements with tabindex="0". This <div> in the keyboard navigation flow, creating invisible Tab stops with no functionality. This are likely to create confusion for screen reader and keyboard users. For this reason I removed tabindex=0 in the ContentPreview component.
Before change
After change
@jstoffan I checked that the functionality of moving files will work when users presses the right and left arrow. This feature works because inside the div where the tabIndex was removed, there are another two tabindexes ( document and thumbnails side bar) and it can trigger the onKeydown events.
@fsuarez-globant, thanks for checking. However, since this attribute was added quite a while ago via 1a0ff4cc72ddfe7031b8ab43c88cdcf04a4b2bcb, I'm concerned we're missing something and risk causing a regression. Does the autofocus feature still work properly? Does left/right work with all file types (images, videos, audio, text, etc.)?
