box-ui-elements icon indicating copy to clipboard operation
box-ui-elements copied to clipboard

Published 20 hours ago • verified publisher icon box

fix(typography): fixed low contrast text on preview

Open msorianoBox opened this issue 3 years ago • 2 comments

Fixed text on the Preview Panel with low contrast (updated value to bdl-gray-80)

Screen Shot 2021-04-12 at 10 06 33 Screen Shot 2021-04-12 at 10 06 25 Screen Shot 2021-04-12 at 10 03 07

msorianoBox avatar Apr 12 '21 15:04 msorianoBox

We do need to change the gray-50 text, but I thought gray-62 met contrast requirements against white backgrounds. Can you clarify why those need to be changed?

alexkrolick avatar Apr 13 '21 01:04 alexkrolick

Gray-62 does meet the contrast requirements against white BG, but in the preview panel the BG color is #FBFBFB and that's why we had to improve the contrast.

msorianoBox avatar Apr 13 '21 14:04 msorianoBox

closing because its stale, there seems to be a change with the exact same variable but to a different color and preview team cannot seem to find an corresponding ticket of the change

greg-in-a-box avatar Aug 30 '22 22:08 greg-in-a-box

https://github.com/box/box-ui-elements/pull/3015 replaces this PR

greg-in-a-box avatar Aug 30 '22 22:08 greg-in-a-box