box-ui-elements icon indicating copy to clipboard operation
box-ui-elements copied to clipboard

Annotation activity enhancement poc

Open ConradJChan opened this issue 4 years ago • 1 comments
trafficstars

Draft for Annotation activity card enhancements.

Few high level callouts:

  • Moved the padding for each activity feed item from the li to a mixin applied to each card so that the annotation card can be full width now that it is interactive
  • Moved the Annotation link inline with the timestamp but had to use a FormattedMessage of on with some margin on each side to provide the adequate spacing to join the timestamp with the annotation link. Open to suggestions if there's a better approach
  • To avoid excessive preventDefault and stopPropagation handling of events within the annotation card, I introduced a concept of isInteractive so that under certain conditions (version is unavailable, the overflow menu is open, or the comment is being edited) the interactivity is removed

This Draft PR is for reference and separate PRs will be broken out for review

annotations card enhancement

ConradJChan avatar Mar 22 '21 21:03 ConradJChan

Added a gif

ConradJChan avatar Mar 22 '21 22:03 ConradJChan