box-ios-sdk
box-ios-sdk copied to clipboard
Add experimental OS X support
- Exclude ALAsset-related code
- Exclude AppToApp authentication
- Add OS X target and scheme, OS X unit test target and scheme
- Updates to handle some differences in keychain behavior on OS X vs. iOS
- Replace UIImage with NSImage on OS X
- Add OS X specific user agent
- Update podspec to support OS X
To do:
- Authentication
- User-friendly names for Mac models to include in user agent
Verified that @clindsay has signed the CLA. Thanks for the pull request!
I'm not crazy about all of the #if TARGET_OS_IPHONE
s strewn about. I think it might be cleaner to move some things into Mac-specific and iOS-specific files at some point. Or at least factor things in such a way that we don't need to use #if's to block out pieces in the middle of a method. But it does create the simplest diff to understand, so I think it's good to start from this and evolve it afterwards.
@RicoYao
@rknottsbox
I agree that the #if TARGET_OS_IPHONE code is a little messy, but it certainly makes it easy to figure out what code is iOS specific.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: Chris Vasselli
:x: rknottsbox
Chris Vasselli seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
This issue has been automatically marked as stale because it has not been updated in the last 30 days. It will be closed if no further activity occurs within the next 7 days. Feel free to reach out or mention Box SDK team member for further help and resources if they are needed.
This issue has been automatically closed due to maximum period of being stale. Thank you for your contribution to Box iOS SDK and feel free to open another PR/issue at any time.