ClusterRunner icon indicating copy to clipboard operation
ClusterRunner copied to clipboard

Published 20 hours ago • verified publisher icon box

Rename "master" and "slave"

Open jamiebuilds opened this issue 6 years ago • 4 comments

Please consider renaming "master/slave" to:

  • Primary/Replica
  • Primary/Secondary
  • Origin/Clone
  • Manager/Worker
  • Parent/Child

Other projects have made similar changes:

  • https://github.com/antirez/redis/issues/3185
  • https://issues.apache.org/jira/browse/COUCHDB-2248
  • https://www.drupal.org/node/2275877

jamiebuilds avatar Apr 26 '18 21:04 jamiebuilds

Thanks for the input, @jamiebuilds. I'm familiar with the controversy. It's not an easy change to make without breaking things and we have limited resources on this project, but if someone would want to offer a pull request that makes this change in a backward compatible way we'd consider merging it.

josephharrington avatar Apr 27 '18 00:04 josephharrington

SMFH, the giant company box has limited resources? "we'd consider merging it" cool.

kennetpostigo avatar Apr 27 '18 20:04 kennetpostigo

@kennetpostigo $2B ain't enough to afford find-and-replace technology these days

jamiebuilds avatar Apr 27 '18 21:04 jamiebuilds

In order to keep the backwards compatibility, we'll create new interfaces with the new naming convention. The existing interfaces will be supported for a pre-defined transition period. We have started working on a a design for this.
This issue will be fixed in the next major release of the product.

Thanks for bringing this up. @jamiebuilds

vartikaz avatar Jun 04 '18 21:06 vartikaz