ClusterRunner icon indicating copy to clipboard operation
ClusterRunner copied to clipboard

Change default value of `error_on_failure` to True in network.py

Open aptxkid opened this issue 9 years ago • 1 comments

By default, failed network requests in ClusterRunner won't raise unless the caller set error_on_failure explicitly. This is generally not pythonic as it's implicit instead of explicit.

aptxkid avatar Jul 13 '15 21:07 aptxkid

I agree with this in principle but just noting that we'd obviously need to be pretty careful about making this change.

josephharrington avatar Jul 13 '15 22:07 josephharrington