box2 icon indicating copy to clipboard operation
box2 copied to clipboard

Compress files on add instead of using Phar::compressFiles (fixes #80)

Open remisauvat opened this issue 8 years ago • 7 comments

Apply file compression when adding a file instead of using Phar::compressFiles at the end. This avoid the issue of opening too many files.

On my project the build even runs faster for ~1200 files.

Tests with compressFiles:

Building...

real    0m23.524s
user    0m14.499s
sys     0m8.972s

New version with compress on the fly

Building...

real    0m19.612s
user    0m10.440s
sys     0m9.135s

remisauvat avatar Apr 07 '16 16:04 remisauvat

Hoping this will get reviewed soon and merged into next release. Since I am restricted to using the Phar file release, I have had to disable compression in order to allow our project to build which has increased the resulting phar file size by 600%

lordgnu avatar Jan 30 '17 17:01 lordgnu

I'm not really convinced of the results: https://github.com/humbug/box/pull/29

Did I miss something?

theofidry avatar Jan 20 '18 19:01 theofidry

I cannot access the blackfire graphs. Can you upload a screenshot ?

remisauvat avatar Jan 22 '18 10:01 remisauvat

Damn, looks like I accidentally deleted them. I'll redo them tonight

theofidry avatar Jan 22 '18 10:01 theofidry

Profiles updated

theofidry avatar Jan 22 '18 23:01 theofidry

Still the link here https://github.com/humbug/box/pull/29#issue-290215315 give a 404 not found

remisauvat avatar Jan 23 '18 11:01 remisauvat

Should be fixed, I forgot to make them public

theofidry avatar Jan 23 '18 11:01 theofidry