box icon indicating copy to clipboard operation
box copied to clipboard

Requirements checker now logs to stderr

Open arnegroskurth opened this issue 2 years ago • 3 comments

Fixes #678

arnegroskurth avatar Jun 22 '22 10:06 arnegroskurth

🤔 not sure why the End-to-End Tests / e2e-Tests: e2e_check_requirements build is failing. The build is passing on master so it should be related, but tee should pick up the stderr

theofidry avatar Jun 24 '22 14:06 theofidry

thinking not sure why the End-to-End Tests / e2e-Tests: e2e_check_requirements build is failing. The build is passing on master so it should be related, but tee should pick up the stderr

I'm not really able to interpret the output but the latter failing test-case seems to complain about failed writes due to potentially full disk: https://github.com/box-project/box/runs/7039442617?check_suite_focus=true#step:6:2056

And I don't think that teeforwards stderr (Try: sh -c "echo foo > /dev/stderr" | tee file.ext) - where is that used? Just setting BOX_REQUIREMENTS_CHECKER_LOG_TO_STDOUT=1 for all tests might be the easiest way out here.

arnegroskurth avatar Jun 24 '22 15:06 arnegroskurth

I'm not really able to interpret the output but the latter failing test-case seems to complain about failed writes due to potentially full disk

Yes you can ignore this one I need to check how to fix it.

where is that used?

In the Makefile. You should be able to run the tests with make e2e_check_requirements

theofidry avatar Jun 24 '22 15:06 theofidry

Thank a lot @arnegroskurth

theofidry avatar Sep 25 '22 09:09 theofidry