box icon indicating copy to clipboard operation
box copied to clipboard

Published 20 hours ago • verified publisher icon box-project

[WIP] Update Windows compatibility

Open pierredup opened this issue 6 years ago • 2 comments

Fixes #193

This PR adds a Appveyor configuration to run CI on Windows machines, and also tries to address some windows compatibility.

There are currrently a lot of failures related to path names (See an example of some of the build failures: https://ci.appveyor.com/project/pierredup/box/build/job/yv2tts08s4ilxft4)) which needs to be updated first to get as much tests as possible to pass, so that the actual Windows issues can be clearly identified.

Appveyor will need to be enabled for this repository, so that all future builds can run against windows to ensure compatibility doesn't break.

pierredup avatar Sep 12 '18 08:09 pierredup

Thanks for looking into this, IIRC @c33s could be interested in it as well :)

Maybe a utility function could be added for normalizing the paths in the tests rather than having to deal with DIRECTORY_SEPARATOR all the time?

Note: I'll enabled AppVeyor on the repo as soon as you think this PR is good

theofidry avatar Sep 12 '18 11:09 theofidry

do we need DIRECTORY_SEPARATOR at all? https://dev.to/c33s/always-use--as-directory-seperator-in-php-43l7

c33s avatar Oct 22 '18 16:10 c33s

I'll be closing this. If one is ready to take up the task once again now GitHub actions supports Windows.

theofidry avatar Oct 21 '23 16:10 theofidry