move "sebastian/diff" to dev, allow ^6 and ^7

Open tacman opened this issue 7 months ago • 1 comments

First, really cool project! Thanks for releasing it.

 "sebastian/diff": "^5.0",

is in the "require" section of composer. Can it be moved to "require-dev"?

Also, diff is at version 7, can this package support 5-7?

May 25 '25 15:05 tacman

Hi,

Indeed that seems to be a mistake, maybe I was using it at some point and it got removed afterwards but forgot to remove the dependency...

Will check that next week, this week is a bit crazy on my end.

May 29 '25 06:05 theofidry

I could check this again.

sebastian/diff is a legitmate source dependency (it is used in the DiffCommand) so it has its place in require rather than require-dev.

I had a look at the releases since 5.x and it does not appear to affect any of the API Box uses so I hope it works. I could not test it because they require newer PHPUnit versions but this project still supports PHP 8.2. I may bump this requirement soon, but not yet.

Sep 06 '25 14:09 theofidry