Split out `XZPetscHermiteSpline`

Open ZedThree opened this issue 4 months ago • 2 comments

Includes #3200 for testing

Split out XZPetscHermiteSpline as a separate implementation, this allows us to remove all the #ifdef mess
Move all the XZInterpolations into the more usual impls/ directory layout

Dec 03 '25 17:12 ZedThree

I unified all the HermiteSpline interpolations, because they have a fair bit in common, it is much easier to keep the different versions aligned.

Maybe we should move some of the #ifdef to if constexpr + templates?

Dec 05 '25 07:12 dschwoerer

Ok, I can make XZHermiteSpline a base class of XZPetscHermiteSpline too to avoid the duplication of the basis calculations. We could also add XZPetscMonotonicHermiteSpline by simply doing the interpolation and clipping afterwards

Dec 05 '25 09:12 ZedThree