BOUT-dev icon indicating copy to clipboard operation
BOUT-dev copied to clipboard

FIXME WHEN COORDINATES REFACTORED

Open dschwoerer opened this issue 2 years ago • 4 comments

Should that have been fixed?

https://bout-dev.readthedocs.io/en/stable/user_docs/new_in_v5.html#fixme-when-coordinates-refactored

dschwoerer avatar Jun 19 '23 13:06 dschwoerer

There's some work currently in place to refactor Coordinates that will hopefully eliminate the need for geometry() entirely, so I think that's still the case.

ZedThree avatar Nov 17 '23 17:11 ZedThree

But that should then be "New in 5.2.0"?

dschwoerer avatar Nov 20 '23 09:11 dschwoerer

No, the text is correct for 5.0.0 (the section heading aside). The calls to geometry() have been removed from the Coordinates ctors, so it must be called manually -- but this is already the case if the user modifies any of the metrics.

ZedThree avatar Nov 20 '23 09:11 ZedThree

Ah, now I get your point. So we should probably change "FIXME WHEN COORDINATES REFACTORED" to "Explicit call to `Coordinates::geometry() required"?

dschwoerer avatar Nov 20 '23 09:11 dschwoerer