food-rescue-robot

food-rescue-robot copied to clipboard

Lots of factories have random behavior, which is a recipe for flaky tests. We saw this recently with the spec added in #112. The flaky behavior was traced to a...

ericfreese

Extract interactors from complex controller actions

2

See https://github.com/collectiveidea/interactor and a5c59b6 - [x] `Volunteers#knight` (#108) - [x] `Volunteers#reactivate` (#109) - [ ] `ScheduleChains#update` - [ ] `ScheduleChains#take` - [ ] `ScheduleChains#leave` - [ ] `Logs#take` - [...

ericfreese

See PR #64. - [ ] `ScheduleChains#show` (@ericfreese in progress) - [ ] `Volunteers#stats` - [ ] `Logs#receipt` - [ ] `Logs#export`

ericfreese

See PRs #85 and #93. From @virtuallybing: > The basic idea is that we’ve catalogued all of the Rubocop offenses that haven’t been looked at in the [`rubocop_todo.yml`](https://github.com/boulder-food-rescue/food-rescue-robot/blob/master/.rubocop_todo.yml) file so...

ericfreese

Rename models to more accurately reflect their actual use

1

Many of the models are not accurately named to describe their role in the app. I was thinking the following could be renamed: ``` ScheduleChain => Route ScheduleVolunteer => RouteVolunteer...

ericfreese

## Overview Move recipients index out to `region_admin` namespace, separate controller. Add integration test. Related to efforts #53 #62

Fosome