inbox-in-gmail icon indicating copy to clipboard operation
inbox-in-gmail copied to clipboard

webpack and gmail.js

Open guybbb opened this issue 5 years ago • 2 comments

  • setInterval is causing some performance issues so I've added gmail.js to try and eliminate it
  • also added webpack with webpack hot reloading for dev
  • update the bundles when clicking on the category navigation bar

Don't think this is ready for merge but if someone wants to help that would be great

guybbb avatar Aug 07 '19 14:08 guybbb

If we're trying to get the extension back onto the Chrome web store, then I'm not sure webpack is a good idea. The moderation team is not happy about extensions with minimized/obfuscated code.

russelldc avatar Aug 08 '19 15:08 russelldc

Webpack doesn't have to minimize / uglify the code. It mainly helps with a smoother development experience (hot reloading) and bundling npm packages

On Thu, Aug 8, 2019, 18:46 Daniel Russell [email protected] wrote:

If we're trying to get the extension back onto the Chrome web store, then I'm not sure webpack is a good idea. The moderation team is not happy about extensions with minimized/obfuscated code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/boukestam/inbox-in-gmail/pull/88?email_source=notifications&email_token=ABEHQQYZTYM5UADKQRO4NWDQDQ5TTA5CNFSM4IKA4USKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD34BMAI#issuecomment-519575041, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEHQQ6HCB2HGOSI22YDTADQDQ5TTANCNFSM4IKA4USA .

guybbb avatar Aug 09 '19 06:08 guybbb